Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DevfileViewer widget #1309

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix DevfileViewer widget #1309

merged 1 commit into from
Feb 4, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Feb 1, 2025

What does this PR do?

Reworked the Devfile Viewer widget. This solution does not change the final package size of 1.91 MB.

Screenshot/screencast of this PR

Знімок екрана 2025-02-01 о 21 10 26
Знімок екрана 2025-02-01 о 21 23 58

What issues does this PR fix or reference?

fixes eclipse-che/che#23324

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Create a new workspace from the source:
https://gist.githubusercontent.com/olexii4/dfb21012e08eedf8fc17ae608708fe87/raw/bec54efa905b915695dcb7fc5806cb4b456aa343/devfile.yaml
  1. Open Workspace Detail / Devfile page and Devfile Viewer styles should be correct:
    Знімок екрана 2025-02-01 о 21 16 43

Release Notes

Docs PR

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested review from vinokurig and akurinnoy and removed request for ibuziuk and akurinnoy February 1, 2025 19:17
@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2025

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 requested a review from ibuziuk February 1, 2025 19:17
Copy link

github-actions bot commented Feb 1, 2025

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1309

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1309", name: che-dashboard}]}}]"

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes missing coverage. Please review.

Project coverage is 91.65%. Comparing base (900f6ef) to head (fefe525).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...oard-frontend/src/components/BasicViewer/index.tsx 0.00% 11 Missing ⚠️
...rd-frontend/src/components/DevfileViewer/index.tsx 0.00% 7 Missing ⚠️
.../pages/WorkspaceDetails/DevfileEditorTab/index.tsx 25.00% 3 Missing ⚠️
...oard-frontend/src/pages/WorkspaceDetails/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
+ Coverage   91.58%   91.65%   +0.07%     
==========================================
  Files         498      499       +1     
  Lines       45447    45474      +27     
  Branches     3165     3156       -9     
==========================================
+ Hits        41622    41680      +58     
+ Misses       3793     3764      -29     
+ Partials       32       30       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested according to the provided description.

Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit f2e8000 into main Feb 4, 2025
20 of 21 checks passed
@olexii4 olexii4 deleted the CHE_23324 branch February 4, 2025 22:56
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/625: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/625: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8707 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8827: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66574012 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Devfile Viewer styles are broken if the target workspace includes just several lines
5 participants