-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DevfileViewer widget #1309
Fix DevfileViewer widget #1309
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1309 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1309", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
+ Coverage 91.58% 91.65% +0.07%
==========================================
Files 498 499 +1
Lines 45447 45474 +27
Branches 3165 3156 -9
==========================================
+ Hits 41622 41680 +58
+ Misses 3793 3764 -29
+ Partials 32 30 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested according to the provided description.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/625: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8707: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.x/5077: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8826: dashboard : 3.x :: Build 66573776 : quay.io/devspaces/dashboard-rhel9:3.19-12 |
Build 3.19 :: update-digests_3.x/8525: Console, Changes, Git Data |
Build 3.19 :: dashboard_3.x/625: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8707 triggered |
Build 3.19 :: operator-bundle_3.x/4399: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8708: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8827: devspaces-operator-bundle : 3.x :: Failed in 66574012 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Reworked the Devfile Viewer widget. This solution does not change the final package size of 1.91 MB.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23324
Is it tested? How?
Release Notes
Docs PR