Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the IDE loading page can't find the target workspace. #214

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Fixed bug that caused the alert message "Failed to find the target workspace." on the IDE loading page while the workspace was loading successfully.

What issues does this PR fix or reference?

fixes eclipse-che/che#19603

@akurinnoy akurinnoy self-assigned this Apr 15, 2021
@akurinnoy akurinnoy changed the title fixed loading workspaces created from samples Fixed the IDE loading page can't find the target workspace. Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #214 (cd0382a) into master (a495d3c) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   49.11%   49.14%   +0.03%     
==========================================
  Files         128      128              
  Lines        4740     4739       -1     
  Branches      775      775              
==========================================
+ Hits         2328     2329       +1     
+ Misses       2177     2176       -1     
+ Partials      235      234       -1     
Impacted Files Coverage Δ
src/store/Workspaces/index.ts 7.75% <0.00%> (+0.05%) ⬆️
src/pages/GetStarted/index.tsx 80.32% <100.00%> (ø)
src/services/workspaceAdapter/index.ts 65.51% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a495d3c...cd0382a. Read the comment docs.

@github-actions
Copy link

Code coverage diff between base branch:master and head branch: fix-ide-loading

File % Stmts % Branch % Funcs % Lines
total 54.22 54.23 40.98 41.03 53.4 53.4 53.96 53.97
src/services/workspaceAdapter/index.ts 80.46 80.46 74.73 75.82 75 75 80.46 80.46
src/store/Workspaces/index.ts 7.87 0 0 7.87

@che-bot
Copy link
Contributor

che-bot commented Apr 15, 2021

✅ E2E dashboard-next tests succeed 🎉

See Details

  • Jenkins job

  • logs and configs

  • Che dashboard-next image:quay.io/crw_pr/che-dashboard:214

  • Che server image: quay.io/crw_pr/che-server:214

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-214

@akurinnoy akurinnoy merged commit 264ff04 into master Apr 15, 2021
@akurinnoy akurinnoy deleted the fix-ide-loading branch April 15, 2021 10:14
@che-bot che-bot added this to the 7.30 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Fail to find the target workspace
4 participants