-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace provision request #357
Conversation
…ration Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357 |
packages/dashboard-frontend/src/services/workspace-client/devworkspace/devWorkspaceClient.ts
Outdated
Show resolved
Hide resolved
❌ E2E dashboard tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 47.84% 47.85%
=======================================
Files 192 191 -1
Lines 6546 6537 -9
Branches 1041 1041
=======================================
- Hits 3132 3128 -4
+ Misses 3126 3121 -5
Partials 288 288
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work as expected from dashboard point of view.
Actually, Che Server failed to provision namespace if it's not there, but it's not related to this PR. I'll report Platform team.
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357 |
…ry resolve operation
…h factory resolve operation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357 |
1 similar comment
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357 |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Added namespace provision request before each workspace/devworkspace related, factory resolve operation.
What issues does this PR fix or reference?
fixes eclipse-che/che#20167