Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace provision request #357

Merged
merged 4 commits into from
Sep 22, 2021
Merged

Add namespace provision request #357

merged 4 commits into from
Sep 22, 2021

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 22, 2021

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added namespace provision request before each workspace/devworkspace related, factory resolve operation.

What issues does this PR fix or reference?

fixes eclipse-che/che#20167

…ration

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357

@che-bot
Copy link
Contributor

che-bot commented Sep 22, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #357 (5843fd2) into main (fb10ae2) will increase coverage by 0.00%.
The diff coverage is 15.38%.

❗ Current head 5843fd2 differs from pull request most recent head e921454. Consider uploading reports for the commit e921454 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   47.84%   47.85%           
=======================================
  Files         192      191    -1     
  Lines        6546     6537    -9     
  Branches     1041     1041           
=======================================
- Hits         3132     3128    -4     
+ Misses       3126     3121    -5     
  Partials      288      288           
Impacted Files Coverage Δ
...ard-frontend/src/services/bootstrap/PreloadData.ts 0.00% <0.00%> (ø)
...hboard-frontend/src/store/FactoryResolver/index.ts 18.46% <0.00%> (-0.29%) ⬇️
...orkspace-client/devworkspace/devWorkspaceClient.ts 17.87% <20.00%> (+0.35%) ⬆️
...rvices/dashboard-backend-client/cheWorkspaceApi.ts 0.00% <0.00%> (-45.46%) ⬇️
packages/dashboard-backend/src/static.ts 0.00% <0.00%> (ø)
...ages/dashboard-backend/src/local-run/che-server.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb10ae2...e921454. Read the comment docs.

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work as expected from dashboard point of view.
Actually, Che Server failed to provision namespace if it's not there, but it's not related to this PR. I'll report Platform team.

@openshift-ci openshift-ci bot removed the lgtm label Sep 22, 2021
@sleshchenko
Copy link
Member

Happy path test failure does not seem to be related to your PR changes:
Screenshot_20210922_173849

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357

1 similar comment
@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Ensure k8s namespace exists before workspace related operation
4 participants