-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factory loading flow refactoring #576
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
+ Coverage 56.01% 58.21% +2.20%
==========================================
Files 221 244 +23
Lines 7477 7878 +401
Branches 1272 1286 +14
==========================================
+ Hits 4188 4586 +398
- Misses 3103 3116 +13
+ Partials 186 176 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c163bcb
to
eaf376f
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR on both platforms(minikube and OpenShift). It works as expected.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! great job
verified locally against dogfooding
It feel like the startup is much faster now
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR splits the whole factory loading functionality into separate components that represent individual steps of the loading flow: StepInitialize, StepFetchResources, StepFetchDevfile, StepCreateWorkspace, StepApplyResources, and StepApplyDevfile.
The other goal of this refactoring was to align factory and workspaces loading flows. It allowed delegating the two last steps of the factory flow (StepStartWorkspace and StepOpenWorkspace) to the workspace loader.
What issues does this PR fix or reference?
resolves eclipse-che/che#21449
fixes eclipse-che/che#21308
Is it tested? How?
The PR can be tested here: https://eclipse-che.apps.cluster-h8r9f.h8r9f.sandbox1016.opentlc.com/