Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the possibility to create an empty workspace #602

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Added the possibility to create an empty workspace #602

merged 6 commits into from
Aug 23, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 9, 2022 •
edited
Loading

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added the possibility to create an empty workspace

What issues does this PR fix or reference?

fixes eclipse-che/che#21554

depends on eclipse-che/che-operator#1486

Is it tested? How?

  1. Deploy CHE and open Create Workspace tab
  2. Click on the Empty Workspace sample

The PR can be tested here: https://eclipse-che.apps.cluster-pdfv6.pdfv6.sandbox1498.opentlc.com/dashboard/

Знімок екрана 2022-08-17 о 16 06 23

@olexii4 olexii4 requested a review from ibuziuk August 9, 2022 09:22
@olexii4 olexii4 requested a review from akurinnoy as a code owner August 9, 2022 09:22
@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@olexii4 olexii4 marked this pull request as draft August 9, 2022 10:43
@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2022

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 marked this pull request as ready for review August 9, 2022 12:48
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 10, 2022

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Aug 10, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 10, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@olexii4
feat: add possibility to create an empty workspace
f83cf4a 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2022

Click here to review and test in web IDE: Contribute

@olexii4
fix: remove old tests
df24158 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 16, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@l0rd
Copy link
Contributor

l0rd commented Aug 16, 2022

I have tested this PR and it worked just fine. A few minor comments that can be addressed later:

  • The community label should be removed as it's not sourced from a community devfile registry
  • The description just says "Empty workspace" (as the title) and something like "Start an empty remote development environment and create files or clone a git repository afterwards" would be better
  • Instead of having one unique "Empty workspace" tile it would be better to have one tile per supported editor. For example for VS Code:
    • Title: "VS Code remote dev environment"
    • Description: "Start an empty VS Code based development environment and create files or clone a git repository afterwards"
    • Icon: VS Code icon
  • Since those are special dev environemnts, I would have them on a dedicated row. In other words after the empty dev environments we should add a new line.

@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

ibuziuk
ibuziuk approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! verified locally against dogfooding
works like a charm 👍

@openshift-ci openshift-ci bot added the lgtm label Aug 18, 2022
@openshift-ci openshift-ci bot removed the lgtm label Aug 23, 2022
@che-bot
Copy link
Contributor

che-bot commented Aug 23, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@che-bot
Copy link
Contributor

che-bot commented Aug 23, 2022

Click here to review and test in web IDE: Contribute

@openshift-ci openshift-ci bot added the lgtm label Aug 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-602

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 93a18e2 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4 olexii4 merged commit b458703 into main Aug 23, 2022
@olexii4 olexii4 deleted the CHE_21554 branch August 23, 2022 19:01
@che-bot che-bot added this to the 7.53 milestone Aug 23, 2022
@nickboldt
Copy link
Contributor

nickboldt commented Dec 14, 2022 •
edited
Loading

This is also in Dev Spaces 3.3:

image

@devstudio-release devstudio-release mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

Assignees

@ibuziuk ibuziuk

@akurinnoy akurinnoy

Labels
lgtm
Projects
None yet
Milestone
7.53
Development

Successfully merging this pull request may close these issues.

Add an IDE-only workspace sample in the Dashboard getting started (without project)
6 participants
@olexii4 @che-bot @l0rd @nickboldt @ibuziuk @akurinnoy