Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and update OPENVSX_REGISTRY_URL before starting #628

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 14, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Check and update OPENVSX_REGISTRY_URL on created workspaces before starting.

What issues does this PR fix or reference?

fixes eclipse-che/che#21654

@olexii4 olexii4 requested a review from ibuziuk September 14, 2022 13:52
@olexii4 olexii4 requested a review from akurinnoy as a code owner September 14, 2022 13:52
@che-bot
Copy link
Contributor

che-bot commented Sep 14, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-628

…ore starting

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-628

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 9f5c5c5 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4 olexii4 merged commit 7646e1a into main Sep 16, 2022
@olexii4 olexii4 deleted the CHE-21654_new branch September 16, 2022 10:14
@che-bot che-bot added this to the 7.54 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard does not respect CheCluster CR changes
5 participants