-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicating requests #878
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-878 |
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 81.53% 81.54% +0.01%
==========================================
Files 346 347 +1
Lines 35750 35962 +212
Branches 2224 2244 +20
==========================================
+ Hits 29147 29325 +178
- Misses 6581 6615 +34
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@akurinnoy please, backport to 7.72.x for 3.8 once merged in main |
@akurinnoy I tested it. I clicked on a sample and Could you fix it too? |
@olexii4 I believe that's another issue not related to this one. |
@olexii4 FYI the fixup I added (4e56d2a) decreases the number of re-renderings of WorkspaceProgress component. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-878 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This pull request fixes a bug that caused the Dashboard to send duplicate requests when creating or starting workspaces.
What issues does this PR fix or reference?
fixes eclipse-che/che#22326
fixes eclipse-che/che#22323
Is it tested? How?
409 Conflict
status.