Use 20.0.0-java8 tag of centos-quarkus-maven #220
Conversation
sunix
requested review from
benoitf,
ericwill,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
| @@ -10,5 +10,5 @@ che-nodejs8-centos registry.centos.org/che-stacks/centos-nodejs | |||
| che-php-7 quay.io/eclipse/che-php-base:7.4 | |||
| che-python-3.6 centos/python-36-centos7:1 | |||
| che-python-3.7 python:3.7.4-slim | |||
| che-quarkus quay.io/quarkus/centos-quarkus-maven:19.2.1 | |||
| che-quarkus quay.io/quarkus/centos-quarkus-maven:20.0.0-java8 | |||
There was a problem hiding this comment.
maybe we could bump to Java11 version as well ? (before it was only providing java8)
There was a problem hiding this comment.
@benoitf Do you want to use Java11 instead of 8 ? or provide both alternatives in our base image ?
There was a problem hiding this comment.
I tested it on che.openshift.io and Start development server command was failed with an error:
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.097 s
[INFO] Finished at: 2020-04-06T09:33:54Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:1.3.1.Final:dev (default-cli) on project getting-started: Detected Maven Version (3.6.1) is not supported, it must be in [3.6.2,). -> [Help 1]
[ERROR]
I'd say it couldn't be merged before fixing that problem
|
@svor we have the same issue with the default stack |
|
looks like this is an issue with 1.3.1-Final, quarkusio/quarkus-quickstarts@ceb711a |
|
@sunix I think we can do that or reference to some specific commit. Could you please update the devfile and try if it works. Or should we crate another issue for that? |
|
@svor it's going to be fixed in the next days I hope quarkusio/quarkus-images#63 so let's wait and I will update my PR with the new version. |
sunix
changed the title
|
@svor quarkusio/quarkus-images#63 (comment) |
sunix
force-pushed
the
centos-quarkus-maven-20.0.0-java8
branch
from
3805283
to
8bc9a59
Compare
|
@svor could you review again ? |
- to fix the build of the default Quarkus sample which has moved Quarkus 1.3.1-Final and requires Maven 3.6.3 - to have native compilation working with the default Quarkus sample
sunix
force-pushed
the
centos-quarkus-maven-20.0.0-java8
branch
from
8bc9a59
to
bc6764c
Compare
There was a problem hiding this comment.
LGTM! As I remember we don't use quay.io/quarkus/centos-quarkus-maven in CRW, we install all tools (GraalVM, Maven, Java) and build our custom image for that. @nickboldt can correct me if I'm wrong.
…lipse-che#220) Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Use latest tag of centos-quarkus-maven: 20.0.0-java8
Needed to have native compilation working with the default Quarkus sample