This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Add tags to meta.yaml #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
|
cc @ashumilova |
skabashnyuk
approved these changes
May 27, 2019
|
@slemeur this PR adds the tags to devfile's metadata for stacks, which we use on UI to bind with project templates (our samples). Just rechecking - we keep the sample projects (which depend on choosen devfile) on workspace creation page, right? |
|
@ashumilova @slemeur I would rather embed the project in the devfile itself. There have been some discussions about how hard it can be to maintain and sync stacks to support n samples. Commands may work on a sample but not having sense for other samples. And we can have some weird associations. Having everything defined at the stack level instead (projects + components + commands) is easier to maintain and easier for a user to choose (he only needs to select the stack). |
l0rd
approved these changes
May 30, 2019
skabashnyuk
added a commit
to skabashnyuk/saas-openshiftio
that referenced
this pull request
Jun 4, 2019
1. eclipse-che/che-devfile-registry#5 Change version of redhat-java plugin to latest 2. eclipse-che/che-devfile-registry#4 Add tags to meta.yaml 3. eclipse-che/che-devfile-registry#7 Added globalMemoryLimit to meta.yaml of devfiles 4. eclipse-che/che-devfile-registry#6 Specify home path in java-maven devfile
johnmcollier
pushed a commit
to johnmcollier/che-devfile-registry
that referenced
this pull request
Apr 14, 2020
use nolsp devfile
Ohrimenko1988
added a commit
that referenced
this pull request
May 15, 2020
Ohrimenko1988
added a commit
that referenced
this pull request
May 29, 2020
sparkoo
pushed a commit
to sparkoo/che-devfile-registry
that referenced
this pull request
Dec 4, 2020
Remove route
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR follows the following discussion #3 (comment)
and it adds tags to meta.yaml.
Values are copied/pasted from existing Che 7 stacks from Che Repository.
What issues does this PR fix or reference?
eclipse-che/che#13353