Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Update dockerfile patch and make new java devfiles used patched images #42

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

amisevsk
Copy link
Contributor

What does this PR do?

  • Update the arbitrary users patch to make sure $HOME is always writable,
    fixing issues with some images.

  • Update java-spring, java-mysql, and java-vertx to use patched images

    • Update the commands in these images since maven wrapper is incompatible with community maven image
    • The base image used for these stacks is changed in this PR: we use maven:3.6.1-jdk-8 instead of registry.centos.org/che-stacks/centos-jdk8 to avoid building another patched image.

One change this makes for the spring images is changing the command to not use the maven wrapper. This wrapper is intended to make it easier to use maven (https://github.com/takari/maven-wrapper/) but appears to not be necessary for the image we are using. Additionally the wrapper is incompatible with the maven community image on OpenShift, since the community image defines $MAVEN_CONFIG=/root/.m2, and the wrapper appears to reuse this env var for (undocumented, afaict) reasons: https://github.com/takari/maven-wrapper/blob/master/mvnw#L301

What issues does this PR fix or reference?

Part of eclipse-che/che#13454, redhat-developer/rh-che#1455, some issues raised in #38 (gradle home not writable)

Tested images:

  • java-vertx, java-spring, java-mysql: Everything works except:

    1. Issue Java-MySQL devfile built app does not work che#13938 is present (in patched and current master images -- i.e. this PR does not fix this issue)
    2. As in some other stacks, a .bashrc already exists so these stacks get an ugly prompt (including workspace ID)
  • java-gradle: This PR fixes the /home/gradle directory not being writable

  • php-simple: This PR fixes the /home/user directory not being writable.

@amisevsk
Copy link
Contributor Author

@sleshchenko Do you foresee any subtle issues resulting from us no longer using the maven wrapper to build the Spring projects? I've tested with default mvn clean install and it seems to work without issue.

Update the arbitrary users patch to make sure $HOME is always writable,
fixing issues with some images.

Update java-spring, java-mysql, and java-vertx to use patched images
  - Update the commands in these images since maven wrapper is
    incompatible with community maven image

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk amisevsk merged commit c1f2d05 into eclipse-che:master Jul 24, 2019
sparkoo pushed a commit to sparkoo/che-devfile-registry that referenced this pull request Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants