Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Add a public method generateDevfileContext #707

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add a public method generateDevfileContext #707

merged 2 commits into from
Jan 23, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 20, 2023

What does this PR do?

This PR brings several improvements for reusing the @eclipse-che/che-devworkspace-generator library in the che-dashboard code:

  1. Add automatic license check.
  2. Add a public method generateDevfileContext.

What issues does this PR fix or reference?

fixes eclipse-che/che#21738

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svor svor merged commit 25f630b into main Jan 23, 2023
@svor svor deleted the CHE-21738 branch January 23, 2023 10:55
@che-bot che-bot added this to the 7.60 milestone Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use DevWorkspace Operator contributions attributes to inject editors into Devfile containers
3 participants