Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git SSL docs #1001

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Update git SSL docs #1001

merged 1 commit into from
Dec 23, 2019

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Add description about how to add an SSL certificate to Che deployed via operator:
screenshot-0 0 0 0_4000-2019 12 (1)

What issues does this PR fix or reference?

eclipse-che/che#15285

Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

We will probably have rework some bits to handle each variant (Kubernetes, Helm) in a different procedure, bit it can happen later.

@themr0c themr0c merged commit 5a3d204 into master Dec 23, 2019
themr0c added a commit that referenced this pull request Dec 23, 2019
* build-docker-image also with podman (#983)

* build-docker-image also with podman

* new container is on quay.io/eclipse/che-docs

* rework building a custom registry image (#998)

* rework building a custom registry image

* fix missing EOF

* refresh ref_che-theia-plug-in-metadata with updated content (#963)

* refresh ref_che-theia-plug-in-metadata with updated content

* fixes to address @AndrienkoAleksandr  comments

* Update git SSL docs (#1001)

* use new container image for devfile - fixes eclipse-che/che/issues/15546 (#1002)

* Clarifications in monitoring chapter (#1000)

* Clarifications in monitoring chapter

* Update src/main/pages/che-7/administration-guide/assembly_monitoring-che.adoc

Co-Authored-By: Florent BENOIT <fbenoit@redhat.com>

* handle feedback from @skabashnyuk - add visibility to enabling and exposing che metrics

* rework Viewing Che metrics on Grafana dashboards

Co-authored-by: Florent BENOIT <fbenoit@redhat.com>

Co-authored-by: Igor Vinokur <ivinokur@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
vinokurig added a commit to eclipse-che/che-operator that referenced this pull request Dec 26, 2019
Add new boolean property gitSelfSignedCertthat applies environment variables that contain SSL certificate and git host written from che-git-self-signed-cert config map.
The same logic is applied for the helm deployment: eclipse-che/che#15218

fixes eclipse-che/che#15285

Docs PR: eclipse-che/che-docs#1001

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
nickboldt pushed a commit to nickboldt/che-operator that referenced this pull request Jan 31, 2020
Add new boolean property gitSelfSignedCertthat applies environment variables that contain SSL certificate and git host written from che-git-self-signed-cert config map.
The same logic is applied for the helm deployment: eclipse-che/che#15218

fixes eclipse-che/che#15285

Docs PR: eclipse-che/che-docs#1001

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig deleted the git-ssl branch March 3, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants