Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of Jar file. #11

Merged
merged 1 commit into from
Dec 26, 2016
Merged

Fix generation of Jar file. #11

merged 1 commit into from
Dec 26, 2016

Conversation

JamesDrummond
Copy link
Contributor

Now It can be extracted on top of codenvy source in target directory.

@bmicklea
Copy link

Should this be reviewed by Sergii?

@JamesDrummond
Copy link
Contributor Author

No. I will discuss with them tomorrow. I pretty much have made it work all the way through. The only difference is I use local maven repo instead of public codenvy repo. They may need to work with it a little to get better folder naming in target directory and version control but they can create another PR if needed.

@JamesDrummond JamesDrummond merged commit b9dd86e into master Dec 26, 2016
@JamesDrummond
Copy link
Contributor Author

Related to eclipse-che/che#3510

@JamesDrummond JamesDrummond deleted the fix-jar branch December 30, 2016 16:52
rkratky pushed a commit that referenced this pull request Aug 26, 2020
max-cx added a commit to max-cx/che-docs that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants