Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ideaIU and WebStorm #1683

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Support ideaIU and WebStorm #1683

merged 4 commits into from
Jan 4, 2021

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Nov 1, 2020 •
edited
Loading

What does this PR do?

This changes proposal describes steps needed to successfully built Eclipse Che editors based on JetBrains products, especially:

  • IntelliJ Idea Community Edition

  • IntelliJ Idea Ultimate Edition

  • WebStorm

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-2161

Specify the version of the product this PR applies to.

CRW 2.5

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

@vzhukovs
Support ideaIU and WebStorm according to RHDEVDOCS-2161
f7abdc2 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs self-assigned this Nov 1, 2020
@azatsarynnyy
Copy link
Member

Hello @themr0c @MichalMaler
Should we open another PR to 7.20.x branch in order to get in CRW 2.5 docs?

benoitf
benoitf reviewed Nov 2, 2020
View reviewed changes
modules/end-user-guide/partials/con_jetbrains-ides.adoc Outdated
= Support JetBrains IDEs

In this section you'll find information about supported JetBrains IDEs
that can be used in Eclipse Che workspace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, FYI due to whitelabelling, Eclipse Che should not be used
{prod} should be used instead

the same for Kubernetes etc.

You may take a look at all attributes there: https://github.com/eclipse/che-docs/blob/master/antora-playbook.yml#L33-L112

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for pointing it.

@vzhukovs
Replace string literals with variables
100e94d 
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@azatsarynnyy azatsarynnyy mentioned this pull request Nov 2, 2020
Closed
16 tasks
@MichalMaler
Copy link
Contributor

Hello @themr0c @MichalMaler
Should we open another PR to 7.20.x branch in order to get in CRW 2.5 docs?

Hello Artem @azatsarynnyy , no need to create another PR. When this will be reviewed and merged, it will be also cherry-picked to 7.20.x and downstream from there to CRW 2.5 docs.

@azatsarynnyy
Copy link
Member

Thank you @MichalMaler for answering!
Okay, waiting for @vzhukovskii to fix the issues to pass the vale-pr-check

@rkratky rkratky self-assigned this Nov 4, 2020
@themr0c themr0c added the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Nov 9, 2020
@azatsarynnyy azatsarynnyy mentioned this pull request Nov 18, 2020
Closed
15 tasks
@themr0c themr0c removed the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Nov 30, 2020
@azatsarynnyy
Copy link
Member

Hello
@themr0c @rkratky @MichalMaler is there anything on our side we can do to move this PR forward?

@azatsarynnyy azatsarynnyy mentioned this pull request Dec 9, 2020
Closed
21 tasks
@yhontyk yhontyk assigned yhontyk and unassigned rkratky Dec 18, 2020
@themr0c
Copy link
Contributor

themr0c commented Dec 18, 2020 •
edited
Loading

Hello @themr0c @MichalMaler
Should we open another PR to 7.20.x branch in order to get in CRW 2.5 docs?

Usually we cherry-pick the resulting commit from master to the 7.20.x branch. We use the need-cherry-pick/7.20.x label to trigger this process.

@themr0c themr0c added the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Dec 18, 2020
@themr0c themr0c assigned rkratky and unassigned yhontyk Dec 18, 2020
@themr0c
Copy link
Contributor

themr0c commented Dec 18, 2020

Hello
@themr0c @rkratky @MichalMaler is there anything on our side we can do to move this PR forward?

@rkratky has started working on it. It's a matter of human bandwidth.

@azatsarynnyy
Copy link
Member

Hello
@themr0c @rkratky @MichalMaler is there anything on our side we can do to move this PR forward?

@rkratky has started working on it. It's a matter of human bandwidth.

Sure. Thank you @themr0c for the reply!

@rkratky rkratky mentioned this pull request Dec 19, 2020
Merged
rkratky
rkratky suggested changes Dec 19, 2020
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review submitted as PR #1758.

@azatsarynnyy
Copy link
Member

Thank you @rkratky for the review!
@vzhukovs will look at #1758

Merge pull request #1758 from rkratky/fix-1683
4ee3f2c 
Fixes in lang., formatting, naming.
@yhontyk yhontyk requested a review from a team as a code owner December 24, 2020 01:32
@yhontyk yhontyk requested a review from rkratky December 24, 2020 01:33
@azatsarynnyy
Copy link
Member

@rkratky can this be merged? It seems everything is good now.

rkratky
rkratky approved these changes Jan 4, 2021
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boczkowska Approved

@yhontyk yhontyk merged commit 568c134 into master Jan 4, 2021
@yhontyk yhontyk deleted the RHDEVDOCS-2161 branch January 4, 2021 11:28
yhontyk pushed a commit that referenced this pull request Jan 4, 2021
Merge pull request #1683 from eclipse/RHDEVDOCS-2161
e49199b 
Support ideaIU and WebStorm
@yhontyk yhontyk added cherry-picked to 7.32.x cherry-picked to 7.32.x and removed need-cherry-pick/7.32.x need cherry-pick to 7.32.x labels Jan 4, 2021
@themr0c
Copy link
Contributor

themr0c commented Jan 22, 2021

This PR should not have landed into 7.20.x. I am reverting the commit in that branch.

themr0c added a commit that referenced this pull request Jan 22, 2021
@themr0c
Revert "Merge pull request #1683 from eclipse/RHDEVDOCS-2161"
88641ab 
This reverts commit e49199b.

No support for Intellij Idea and Webstorm in 7.20.x.
@themr0c themr0c removed the cherry-picked to 7.32.x cherry-picked to 7.32.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf left review comments

@yhontyk yhontyk yhontyk approved these changes

@rkratky rkratky rkratky approved these changes

@themr0c themr0c Awaiting requested review from themr0c

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@l0rd l0rd Awaiting requested review from l0rd

Assignees

@vzhukovs vzhukovs

@rkratky rkratky

Labels
kind/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vzhukovs @azatsarynnyy @MichalMaler @themr0c @benoitf @rkratky @yhontyk @che-bot