Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add instructions how to add a manuall PAT secret #2383

Merged
merged 16 commits into from
Jul 27, 2022
Merged

chore: Add instructions how to add a manuall PAT secret #2383

merged 16 commits into from
Jul 27, 2022

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jun 21, 2022 •
edited
Loading

What does this pull request change?

Add instructions how to add a manuall PAT secret to be able to create factory from private repo if oAuth is not configured.

What issues does this pull request fix or reference?

eclipse-che/che#21189
depends on eclipse-che/che-server#313

Specify the version of the product this pull request applies to

next

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from rkratky, themr0c and a team as code owners June 21, 2022 11:23
@vinokurig vinokurig requested review from azatsarynnyy and removed request for a team June 21, 2022 11:23
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

🎊 Navigate the preview: https://62dfb2f9d88ff35cbf0cf30c--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@vinokurig vinokurig force-pushed the che-21189 branch 2 times, most recently from 13288de to 2c74e93 Compare June 21, 2022 11:52
@vinokurig
chore: Add instructions how to add a manuall PAT secret
ad605ce 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
rkratky
rkratky suggested changes Jun 28, 2022
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig, review with a bunch of nitpicks submitted.

modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/pages/configuring-a-git-provider-access-token.adoc Outdated Show resolved Hide resolved
vinokurig and others added 7 commits June 29, 2022 08:45
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
778590f 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
4882d89 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
061efb8 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
47aa652 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
b88d373 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
c5fa87a 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@vinokurig
Update modules/end-user-guide/pages/configuring-a-git-provider-access…
d2adf6e 
…-token.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com>
@max-cx
Copy link
Contributor

max-cx commented Jun 29, 2022

We also need an unordered list item to be added about this functionality in
https://github.com/eclipse-che/che-docs/edit/main/modules/end-user-guide/pages/using-credentials-and-configurations-in-workspaces.adoc#L14

@max-cx
Copy link
Contributor

max-cx commented Jun 29, 2022

I've a question: we currently have another procedure that involves a token:
https://www.eclipse.org/che/docs/next/end-user-guide/using-a-git-credentials-store/.

Is there any use case in which that other procedure is inapplicable and this procedure is needed?

Suppose I'm a reader and I see these two procedures in the docs, which one should I choose and why?

@dkwon17, you authored the published token procedure. Maybe you could contribute to this discussion?

@vinokurig
Copy link
Contributor Author

@rkratky Could you please take a look.

@max-cx max-cx self-assigned this Jul 11, 2022
@vinokurig
Copy link
Contributor Author

@max-cx @rkratky any updates?

@max-cx max-cx mentioned this pull request Jul 15, 2022
Merged
6 tasks
@vinokurig
Copy link
Contributor Author

@max-cx @rkratky Are we ready to merge it?

@max-cx
Copy link
Contributor

max-cx commented Jul 25, 2022

Apologies for the delays. I will review it ASAP.

@vinokurig @max-cx
Update modules/end-user-guide/partials/proc_using-a-git-provider-acce…
d9fe974 
…ss-token.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>
@max-cx
Copy link
Contributor

max-cx commented Jul 26, 2022 •
edited
Loading

When merged, this needs to be cherry-picked into the 7.50.x branch.

rkratky
rkratky approved these changes Jul 26, 2022
View reviewed changes
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks. Preapproving.

modules/end-user-guide/partials/proc_using-a-git-credentials-store.adoc Show resolved Hide resolved
modules/end-user-guide/partials/proc_using-a-git-provider-access-token.adoc Show resolved Hide resolved
modules/end-user-guide/partials/proc_using-a-git-provider-access-token.adoc Show resolved Hide resolved
@vinokurig vinokurig merged commit 1018b12 into main Jul 27, 2022
@vinokurig vinokurig deleted the che-21189 branch July 27, 2022 09:13
@che-bot che-bot added this to the 7.51 milestone Jul 27, 2022
vinokurig added a commit that referenced this pull request Jul 27, 2022
@vinokurig
chore: Add instructions how to add a manuall PAT secret (#2383)
bbdaec7 
Add instructions how to add a manuall PAT secret to be able to create factory from private repo if oAuth is not configured.
@vinokurig vinokurig mentioned this pull request Jul 27, 2022
Merged
6 tasks
vinokurig added a commit that referenced this pull request Jul 27, 2022
@vinokurig
chore: Add instructions how to add a manuall PAT secret (#2383) (#2409)
abff8de 
Add instructions how to add a manuall PAT secret to be able to create factory from private repo if oAuth is not configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-cx max-cx max-cx approved these changes

@rkratky rkratky rkratky approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@themr0c themr0c Awaiting requested review from themr0c

Assignees

@max-cx max-cx

Labels
backported to 7.50.x target/branch
Projects
None yet
Milestone
7.51
Development

Successfully merging this pull request may close these issues.
6 participants
@vinokurig @max-cx @dkwon17 @azatsarynnyy @rkratky @che-bot