feat: add documentation about required network policy for multitentan… #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwon17
requested review from
rkratky,
themr0c,
max-cx and
a team
as code owners
|
Click here to review and test in web IDE: |
|
🎊 Navigate the preview: https://6310f59e6d20fe37e693c5f2--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
dkwon17
commented
Aug 29, 2022
modules/administration-guide/pages/networking-requirements.adoc
Outdated
Show resolved
Hide resolved
dkwon17
commented
Aug 29, 2022
| @@ -0,0 +1,40 @@ | |||
| :_content-type: CONCEPT | |||
There was a problem hiding this comment.
If this should be a procedure, I could change it and provide the prerequisites and a 1 step procedure to apply the network policy
There was a problem hiding this comment.
I don't think we need to convert this concept module into a procedure module because most of the content is conceptual and because the procedure is already documented on the linked page, https://docs.openshift.com/container-platform/4.10/networking/network_policy/multitenant-network-policy.html.
dkwon17
force-pushed
the
multitenant-isolation
branch
2 times, most recently
from
db005b4 to
d171dcc
Compare
…t isolation Signed-off-by: dkwon17 <dakwon@redhat.com>
dkwon17
force-pushed
the
multitenant-isolation
branch
from
d171dcc to
894c52e
Compare
max-cx
requested changes
Sep 1, 2022
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/partials/snip_configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
…s.adoc Co-authored-by: David Kwon <dakwon@redhat.com>
max-cx
approved these changes
Sep 1, 2022
max-cx
reviewed
Sep 1, 2022
modules/administration-guide/pages/configuring-network-policies.adoc
Outdated
Show resolved
Hide resolved
…s.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
themr0c
pushed a commit
that referenced
this pull request
Sep 2, 2022
#2432) Co-authored-by: Max Leonov <mleonov@redhat.com> Co-authored-by: David Kwon <dakwon@redhat.com>
themr0c
pushed a commit
that referenced
this pull request
Sep 2, 2022
#2432) Co-authored-by: Max Leonov <mleonov@redhat.com> Co-authored-by: David Kwon <dakwon@redhat.com>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Sep 5, 2022
eclipse-che#2432) Co-authored-by: Max Leonov <mleonov@redhat.com> Co-authored-by: David Kwon <dakwon@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t isolation
Signed-off-by: dkwon17 dakwon@redhat.com
What does this pull request change?
This PR adds documentation about the required NetworkPolicy for when there are networking restrictions between pods from different namespaces.
Preview:
What issues does this pull request fix or reference?
Fixes: eclipse-che/che#21648
Specify the version of the product this pull request applies to
All versions
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.