Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configuring a user namespace #2674

Merged
merged 11 commits into from
Feb 13, 2024
Merged

feat: configuring a user namespace #2674

merged 11 commits into from
Feb 13, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 23, 2024

What does this pull request change?

configuring a user namespace

What issues does this pull request fix or reference?

eclipse-che/che#20501

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@tolusha tolusha requested review from deerskindoll and a team as code owners January 23, 2024 14:13
@tolusha tolusha requested a review from ibuziuk January 23, 2024 14:13
Copy link

github-actions bot commented Jan 23, 2024

🎊 Navigate the preview: https://65cb4f781571e4073776962d--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Jan 23, 2024

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get rid of the Vale error first to generate a preview of the doc.

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small edits

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tolusha
Copy link
Contributor Author

tolusha commented Feb 1, 2024

@deerskindoll
Can I merge with failed PR checks?

@deerskindoll
Copy link
Contributor

@deerskindoll Can I merge with failed PR checks?

I'll ask how to fix it. there's no visible error that I see

tolusha and others added 11 commits February 13, 2024 12:11
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…e.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit fbfd367 into main Feb 13, 2024
10 checks passed
@tolusha tolusha deleted the 20501 branch February 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants