feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719

maheshrajrp · 2024-04-14T14:40:49Z

What does this pull request change?

Addition of Support for Che with vCluster

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

7.82

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

Any procedure:
- Successfully tested.
Any page or link rename:
- The page contains a redirection for the previous URL.
- Propagate the URL change in:
  - Dashboard default branding data
Builds on Eclipse Che hosted by Red Hat.
the Validate language on files added or modified step reports no vale warnings.

github-actions · 2024-04-14T14:41:03Z

🎊 Navigate the preview: https://6656f23d1575547e71c0dfaa--eclipse-che-docs-pr.netlify.app 🎊

github-actions · 2024-04-14T14:41:03Z

Click here to review and test in web IDE:

maheshrajrp · 2024-04-14T14:44:58Z

@tolusha @deerskindoll @ibuziuk reopened PR with the latest changes.

tolusha · 2024-04-15T07:26:29Z

@deerskindoll
Could you confirm that the article has to be split into smaller ones?
If so, I can help with that.

this is a question for @maheshrajrp.

maheshrajrp · 2024-04-15T10:02:14Z

@deerskindoll
Could you confirm that the article has to be split into smaller ones?
If so, I can help with that.

this is a question for @maheshrajrp.

hi @tolusha
im not sure if we could split this, the best we could do is move just the keycloak setup. the client id, secret creation are still needed. i fear it might do more harm than it's worth it ?

in any case, do you have thoughts or suggestions @tolusha @deerskindoll ?

deerskindoll · 2024-04-15T10:24:04Z

I'm worried about the readability and clarity of the process. It's really long and involves many components that go beyond the process of installation. I'd prefer to shift keyclok setup to a separate process and add it as a prerequisite to the installation itself. Let me check with another writer for a second opinion.

@maheshrajrp I need you to include the fix for the missing attribute issue, the build and verify PR workflow won't passs otherwise. There's also a potential issue with the usage of [source,shell] but I need to look into it more.

maheshrajrp · 2024-04-15T10:27:00Z

I'm worried about the readability and clarity of the process. It's really long and involves many components that go beyond the process of installation. I'd prefer to shift keyclok setup to a separate process and add it as a prerequisite to the installation itself. Let me check with another writer for a second opinion.

@maheshrajrp I need you to include the fix for the missing attribute issue, the build and verify PR workflow won't passs otherwise. There's also a potential issue with the usage of [source,shell] but I need to look into it more.

@deerskindoll can you give some hints on what you mean by attributes issues or point me to some documentation? it would really help.. first-time contributor here, sorry and thanks !!

deerskindoll · 2024-04-15T10:38:49Z

No worries. I left the suggestion in your original PR. {domain_name} and {keycloak_host} are causing an asciidoc issue because asciidoc treats them as attributes.

You need to add a backslash \ to avoid this error: \{domain_name} and {{keycloak_host}`

deerskindoll · 2024-04-15T15:15:55Z

There are two more issues with the code blocks:

[source, shell] https://redhat-documentation.github.io/supplementary-style-guide/#code-example-syntax-highlighting
removing the $ prefix https://redhat-documentation.github.io/supplementary-style-guide/#commands-with-root-privileges

Can you please fix these issues?

maheshrajrp · 2024-04-16T13:29:31Z

@deerskindoll . Thanks for the hints. I can understand. Will fix those issues. Give me a day or two (as right now I am in the middle of a career crisis), I'll pick it up and complete it asap.

deerskindoll · 2024-04-18T20:05:47Z

@deerskindoll . Thanks for the hints. I can understand. Will fix those issues. Give me a day or two (as right now I am in the middle of a career crisis), I'll pick it up and complete it asap.

Take you time, there's no pressure here.

tolusha · 2024-05-06T06:52:12Z

Hello @maheshrajrp
How are you?

maheshrajrp · 2024-05-18T11:56:42Z

Hi @tolusha ,
I've made some changes to the PR. Can we trigger build now to validate ?

tolusha · 2024-05-21T07:14:23Z

@deerskindoll
Could you have a look please?

deerskindoll · 2024-05-21T10:45:12Z

@deerskindoll Could you have a look please?

The pipeline ran successfully and PR preview is available now. I noticed that in the navigation, the articles are organized like this:

That's not correct, is it? Virtual kubernetes installation, cloud installation and local installation are 3 separate processes on the same level, aren't they?

maheshrajrp · 2024-05-22T05:11:25Z

@deerskindoll Could you have a look please?

The pipeline ran successfully and PR preview is available now. I noticed that in the navigation, the articles are organized like this:

That's not correct, is it? Virtual kubernetes installation, cloud installation and local installation are 3 separate processes on the same level, aren't they?

Yes, those need to separated. If you guys could give an hint about what went wrong, I'll fix it. I did some comparison and still fail to identify the root issue. It would be great if you could help on that. Thanks

modules/administration-guide/nav.adoc

deerskindoll · 2024-05-23T10:24:01Z

@deerskindoll Could you have a look please?

I'm on it but I need some time to figure out how to best present the procedure. I'll try splitting it into 2-3 smaller chunks for better readability.

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

tolusha · 2024-05-27T08:41:56Z

@maheshrajrp
Sounds good for me.

@deerskindoll

deerskindoll

last small change.

modules/administration-guide/pages/installing-che-on-the-virtual-kubernetes-cluster.adoc

deerskindoll

the procedure is very complex and not easy to split, let's keep it as is.

…al-kubernetes-cluster.adoc Typo Changes Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

maheshrajrp · 2024-05-27T15:15:35Z

@tolusha @deerskindoll made the requested change.

tolusha · 2024-05-28T08:41:11Z

@maheshrajrp
Thank you a lot for the contribution.
We really appreciate that.

maheshrajrp · 2024-05-28T08:44:10Z

@maheshrajrp
Thank you a lot for the contribution.
We really appreciate that.

Thanks for merge @tolusha. And sorry for the delay.. got caught in middle of some picky situations..

Additionally, I'll look into contributing to a few other documentations, too.

Thanks for your review and support !! Was insightful..

Che on vCluster

2b92975

maheshrajrp requested review from deerskindoll and a team as code owners April 14, 2024 14:40

maheshrajrp requested a review from svor April 14, 2024 14:40

maheshrajrp changed the title ~~Che on vCluster~~ feat: Deploy Eclipse Che on a virtual Kubernetes cluster Apr 14, 2024

maheshrajrp mentioned this pull request Apr 14, 2024

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2701

Closed

5 tasks

maheshraj.rp added 2 commits May 18, 2024 17:15

Backslash Issue

dd16e54

Source Shell Issue Fixes

74d6dcb

tolusha reviewed May 22, 2024

View reviewed changes

modules/administration-guide/nav.adoc Outdated Show resolved Hide resolved

Update modules/administration-guide/nav.adoc

5945e7f

Co-authored-by: Anatolii Bazko <abazko@redhat.com>

deerskindoll reviewed May 27, 2024

View reviewed changes

modules/administration-guide/pages/installing-che-on-the-virtual-kubernetes-cluster.adoc Outdated Show resolved Hide resolved

deerskindoll approved these changes May 27, 2024

View reviewed changes

Update modules/administration-guide/pages/installing-che-on-the-virtu…

5a5df17

…al-kubernetes-cluster.adoc Typo Changes Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

tolusha approved these changes May 28, 2024

View reviewed changes

tolusha merged commit be21279 into eclipse-che:main May 28, 2024
5 of 6 checks passed

maheshrajrp deleted the install_in_vcluster branch June 5, 2024 05:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719

maheshrajrp commented Apr 14, 2024 •

edited

Loading

github-actions bot commented Apr 14, 2024 •

edited

Loading

github-actions bot commented Apr 14, 2024 •

edited

Loading

maheshrajrp commented Apr 14, 2024

tolusha commented Apr 15, 2024 •

edited by deerskindoll

Loading

maheshrajrp commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

maheshrajrp commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

maheshrajrp commented Apr 16, 2024 •

edited

Loading

deerskindoll commented Apr 18, 2024

tolusha commented May 6, 2024

maheshrajrp commented May 18, 2024

tolusha commented May 21, 2024

deerskindoll commented May 21, 2024

maheshrajrp commented May 22, 2024

deerskindoll commented May 23, 2024

tolusha commented May 27, 2024

deerskindoll left a comment

deerskindoll left a comment

maheshrajrp commented May 27, 2024

tolusha commented May 28, 2024

maheshrajrp commented May 28, 2024

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719

feat: Deploy Eclipse Che on a virtual Kubernetes cluster #2719

Conversation

maheshrajrp commented Apr 14, 2024 • edited Loading

What does this pull request change?

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

github-actions bot commented Apr 14, 2024 • edited Loading

github-actions bot commented Apr 14, 2024 • edited Loading

maheshrajrp commented Apr 14, 2024

tolusha commented Apr 15, 2024 • edited by deerskindoll Loading

maheshrajrp commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

maheshrajrp commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

deerskindoll commented Apr 15, 2024

maheshrajrp commented Apr 16, 2024 • edited Loading

deerskindoll commented Apr 18, 2024

tolusha commented May 6, 2024

maheshrajrp commented May 18, 2024

tolusha commented May 21, 2024

deerskindoll commented May 21, 2024

maheshrajrp commented May 22, 2024

deerskindoll commented May 23, 2024

tolusha commented May 27, 2024

deerskindoll left a comment

Choose a reason for hiding this comment

deerskindoll left a comment

Choose a reason for hiding this comment

maheshrajrp commented May 27, 2024

tolusha commented May 28, 2024

maheshrajrp commented May 28, 2024

maheshrajrp commented Apr 14, 2024 •

edited

Loading

github-actions bot commented Apr 14, 2024 •

edited

Loading

github-actions bot commented Apr 14, 2024 •

edited

Loading

tolusha commented Apr 15, 2024 •

edited by deerskindoll

Loading

maheshrajrp commented Apr 16, 2024 •

edited

Loading