Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https deploy doc #822

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fix https deploy doc #822

merged 2 commits into from
Sep 19, 2019

Conversation

sleshchenko
Copy link
Member

What does this PR do?

  1. Fixes typo
  2. Aligns AWS YAML section options with Azure and GCP ones, to make * displayable. Maybe there are more preferable ways to make * displayable, but I just did in the same way as other similar docs have.

What issues does this PR fix or reference?

It fixes a documentation issue a used faced in eclipse-che/che#14584

themr0c
themr0c approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themr0c themr0c merged commit 7d79152 into eclipse-che:master Sep 19, 2019
@sleshchenko sleshchenko deleted the fixHttpsDeployDoc branch September 19, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themr0c themr0c themr0c approved these changes

@rkratky rkratky Awaiting requested review from rkratky

@slemeur slemeur Awaiting requested review from slemeur

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleshchenko @themr0c @che-bot