Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation guide - namespace per user strategy #825

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Sep 23, 2019

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

document namespace strategy - namespace per user

What issues does this PR fix or reference?

eclipse-che/che#14624

@sparkoo sparkoo marked this pull request as ready for review September 23, 2019 15:47
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the content to be published, the file will need to be included in the docs structure (see https://hackmd.io/c0nqIQK2Rki1u95h9h1X1Q). Please, let me know if you need help with that.

Signed-off-by: Michal Vala <mvala@redhat.com>
Co-Authored-By: Robert Krátký <rkratky@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Sep 26, 2019

I've fixed all comments and create new issue to document remaining strategies eclipse-che/che#14666. I can make the document public, but I would do that once all strategies are documented. WDYT @rkratky ?

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Sep 30, 2019

I've added page metadata header. Anything else needs to be done to publish the page @rkratky ?

@themr0c
Copy link
Contributor

themr0c commented Sep 30, 2019

In the current state @sparkoo, if we merge the PR, it would publish https://www.eclipse.org/che/docs/che-7/configuring-namespace-strategies/ without making it visible in the menu (as the Installation Guide is currently disabled in the menu). Is it what you expect?

Another question @sparkoo: would it make sense to have one procedure explaining how to to configure any namespace strategy + one reference explaining which namespace strategies are available?

@sparkoo
Copy link
Member Author

sparkoo commented Sep 30, 2019

I'd like to ask you @themr0c if you think this page should be published in current state and how? Because my opinion is, that it does not make much sense without other strategies at least mentioned.

I guess I'll have to write short paragraph about other strategies here to have this PR mergeable and page usable. Then we could publish it.

…aces strategies

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Sep 30, 2019

@rkratky @themr0c I've updated the doc with other 2 strategies. Now I think it's publishable. Please review. Also how could I make it reachable from sidebar menu?

@themr0c
Copy link
Contributor

themr0c commented Sep 30, 2019

It looks great @sparkoo. Thank you!
The sidebar is configured there: https://github.com/eclipse/che-docs/blob/master/src/main/_data/sidebars/che_7_docs.yml
As the installation guide is completely empty now, I am not sure we should enable it right now, or point the fact that this doc should be enabled when publishing the Installation Guide in eclipse-che/che#14362. What is your advice on the topic @rkratky ?

Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themr0c themr0c dismissed rkratky’s stale review October 1, 2019 07:11

As the installation guide is completely empty now, I am not sure we should enable it right now, or point the fact that this doc should be enabled when publishing the Installation Guide

@themr0c themr0c merged commit 3311ea1 into eclipse-che:master Oct 1, 2019
@sparkoo sparkoo deleted the namespaceStrategies branch October 1, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants