Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git self sign #936

Merged
merged 6 commits into from
Nov 28, 2019
Merged

Git self sign #936

merged 6 commits into from
Nov 28, 2019

Conversation

vparfonov
Copy link
Contributor

What does this PR do?

What issues does this PR fix or reference?

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@rkratky
Copy link

rkratky commented Nov 24, 2019

@vparfonov, I suggested some fixes in #939

@rkratky
Copy link

rkratky commented Nov 26, 2019

@vparfonov, is this ready to be merged, or are you going to be adding the content for OpenShift, too?

@vparfonov
Copy link
Contributor Author

vparfonov commented Nov 28, 2019

@rkratky we can merge it and later I will add information about OpenShift in other PR after fixing eclipse-che/che#15285

@rkratky rkratky merged commit c211fcb into master Nov 28, 2019
@rkratky rkratky deleted the gitSelfSign branch November 28, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants