Apply latest che-machine-exec changes. #15
Conversation
AndrienkoAleksandr
requested review from
skabashnyuk,
garagatyi and
sleshchenko
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Dockerfile
Outdated
| @@ -15,6 +15,7 @@ WORKDIR /go/src/github.com/eclipse/che-machine-exec/ | |||
| COPY . . | |||
| RUN CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-w -s' -a -installsuffix cgo -o che-machine-exec . | |||
|
|
|||
| FROM registry.centos.org/centos:7 | |||
| FROM alpine:3.8 | |||
There was a problem hiding this comment.
curious, we're not able to use scratch image ?
https://medium.com/@chemidy/create-the-smallest-and-secured-golang-docker-image-based-on-scratch-4752223b7324#ae0c
There was a problem hiding this comment.
Yes, thanks, We can. Size will be really less: from 30.3 Mb to 29.9 Mb.
There was a problem hiding this comment.
che-machine-exec binary -> 24Mb
There was a problem hiding this comment.
do we know what inside is taking so much data ?
There was a problem hiding this comment.
We use client libraries to work with kubernetes and docker. That's why I think it has such size.
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Dockerfile
Outdated
| WORKDIR /go/src/github.com/eclipse/che-machine-exec/ | ||
| COPY . . | ||
| RUN CGO_ENABLED=0 GOOS=linux go build -a -ldflags '-w -s' -a -installsuffix cgo -o che-machine-exec . | ||
| RUN apk add --no-cache ca-certificates | ||
|
|
||
| FROM alpine:3.8 |
There was a problem hiding this comment.
we're still using from alpine instead of scratch ?
There was a problem hiding this comment.
Used scratch image - 25.5 Mb. che-machine-exec binary -> 24Mb. Tested on the openshift.io - works.
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
@benoitf I want to merge this pull request. You Don't mind? |
|
@AndrienkoAleksandr sure, was only question from my side |
References issue:
#13
Add kubernetes implementation.
Use alpine image like base for Dockerfile.