-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Syncing of proxy settings and self-signed cert to the user's workspace namespace #1027
Conversation
Skipping CI for Draft Pull Request. |
/retest |
"k8s.io/apimachinery/pkg/runtime" | ||
) | ||
|
||
type DevworkspaceState int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type DevworkspaceState int | |
type DevWorkspaceState int |
it would be a consistent naming I think, but that's not critical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, from looking at CO codebase, we're consistently "Devworkspace" :) So I'd like to keep it out of this PR and deal with it in another issue. But you're of course right, we should use the same terminology...
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: metlos, sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>
New changes are detected. LGTM label has been removed. |
New changes are detected. LGTM label has been removed. |
@tolusha, a Yes/No question about this issue: Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide? Yes/No? |
@metlos, could you please clarify what the user experience impact of this is (for the sake of writing the Release Notes text)? |
@max-cx |
What does this PR do?
Reference: https://issues.redhat.com/browse/CRW-2397
This adds the ability to sync settings to the workspace namespaces of the users.
The new controller watches namespaces (or projects on OpenShift). If a namespace has appropriate label (
org.eclipse.che/workspace-namespace-owner-uid
), it is considered a user workspace namespace and is synced to.The value of the label is supposed to be the UID of the user. On OpenShift, this is the UID of the user object and on Kubernetes, the UID of the user as obtained from the OAuth token of the configured OIDC provider.
What issues does this PR fix or reference?
eclipse-che/che#20168
How to test this PR?
create a namespace, label it and check that the proxy settings are synced to it in a config map and self signed certificates in a secret.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.