Add devWorkspace.runningLimit field to CheCluster schema

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Add devWorkspace.runningLimit field into CheCluster schema:

                    runningLimit:
                      description: Defined quantity maximal running workspaces per user.
                      type: number

Screenshot/screencast of this PR

You can test it with Dashboard swagger ${CHE_HOST}/dashboard/api/swagger/static/index.html#/clusterConfig/get_dashboard_api_cluster_config

What issues does this PR fix or reference?

fixes eclipse-che/che#21032

How to test this PR?

To deploy:
Can be tested by following these steps: https://github.com/eclipse-che/che-operator#deploy-che-operator-with-chectl-using---installer-operator-flag

I have tested it with platform minikube and this che-operator image: docker.io/olexii4dockerid/che-operator:next.

Example:

chectl server:deploy \
    --installer=operator \
    --platform=minikube \
    --che-operator-image=docker.io/olexii4dockerid/che-operator:next

1. Deploy Eclipse-CHE with operator-image docker.io/olexii4dockerid/che-operator:next.
2. Pach checlusters/eclipse-che with command

kubectl patch checlusters/eclipse-che --patch "{\"spec\":{\"devWorkspace\":{\"runningLimit\":2}}}" -n eclipse-che --type=merge

3. Open ${CHE_HOST}/dashboard/api/swagger and get clusterConfig. The running limit should be 2.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• Custom resource definition file is up to date
• OLM bundles are up to date
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ibuziuk]

Let's use spec.devworkspace.runningLimit - eclipse-che/che-dashboard#475 (comment)

[ibuziuk]

I believe you need to change api/v1/checluster_types.go https://github.com/eclipse-che/che-operator#checluster-custom-resource and then run make update-resources -s

[ibuziuk]

#1335 (comment)

[tolusha]

The correct way to add new fields to CheCluster CRD is:

1. Update https://github.com/eclipse-che/che-operator/blob/main/api/v1/checluster_types.go
2. Run make update-resources
3. Commit all changes

[codecov]

Codecov Report

Merging #1335 (db4cdc2) into main (e78b0be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files          77       77           
  Lines        6346     6346           
=======================================
  Hits         3841     3841           
  Misses       2119     2119           
  Partials      386      386           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78b0be...db4cdc2. Read the comment docs.

[ibuziuk]

@olexii4 @tolusha folks, I opened #1338 in favour of this PR. WDYT can we close this one and review #1338 instead?