Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure Open VSX registry URL #1466

Merged
merged 2 commits into from
Aug 3, 2022
Merged

feat: Configure Open VSX registry URL #1466

merged 2 commits into from
Aug 3, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 2, 2022

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@@ -242,6 +242,9 @@ type PluginRegistry struct {
// External plugin registries.
// +optional
ExternalPluginRegistries []ExternalPluginRegistry `json:"externalPluginRegistries,omitempty"`
// Open VSX registry URL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Open VSX registry URL.
// Open VSX registry URL. If omitted an embedded instance will be used.
// To use the Eclipse Foundation operated online service set to `https://openvsx.org`

@openshift-ci openshift-ci bot added the lgtm label Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf
Copy link
Contributor

benoitf commented Aug 2, 2022

I'm wondering if we need 'Registry' in the name of the field OpenVSXRegistryURL or just OpenVSXURL ?
but no strong opinion on both choices

@l0rd
Copy link
Contributor

l0rd commented Aug 2, 2022

I'm wondering if we need 'Registry' in the name of the field OpenVSXRegistryURL or just OpenVSXURL ? but no strong opinion on both choices

Yeah maybe that may be better since we already have the registry word in the pluginRegistry.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci

This comment was marked as outdated.

@tolusha
Copy link
Contributor Author

tolusha commented Aug 3, 2022

@benoitf
devworkspace-happy-path is very unstable. I always tries to investigate logs to find out the number of failed tests.
It is usually like:

  19 passing (10m)
  1 failing

So, I count it as good to merge if all other PR checks passed.

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 2b46861 link true /test v9-devworkspace-happy-path
ci/prow/v11-devworkspace-happy-path 2b46861 link true /test v11-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 7f051fa into main Aug 3, 2022
@tolusha tolusha deleted the 21598 branch August 3, 2022 07:35
@che-bot che-bot added this to the 7.52 milestone Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants