-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configure Open VSX registry URL #1466
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
api/v2/checluster_types.go
Outdated
@@ -242,6 +242,9 @@ type PluginRegistry struct { | |||
// External plugin registries. | |||
// +optional | |||
ExternalPluginRegistries []ExternalPluginRegistry `json:"externalPluginRegistries,omitempty"` | |||
// Open VSX registry URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Open VSX registry URL. | |
// Open VSX registry URL. If omitted an embedded instance will be used. | |
// To use the Eclipse Foundation operated online service set to `https://openvsx.org` |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: l0rd, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm wondering if we need 'Registry' in the name of the field |
Yeah maybe that may be better since we already have the |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
New changes are detected. LGTM label has been removed. |
This comment was marked as outdated.
This comment was marked as outdated.
@benoitf
So, I count it as good to merge if all other PR checks passed. |
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
feat: Configure Open VSX registry URL
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21598
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.