Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missed user roles #1532

Merged
merged 3 commits into from
Oct 6, 2022
Merged

chore: Add missed user roles #1532

merged 3 commits into from
Oct 6, 2022

Conversation

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion that it would be nice to have the same ordering convention for verbs across resources e.g. "get", "list", "create", "watch", "delete" etc

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha closed this Oct 5, 2022
@tolusha tolusha reopened this Oct 5, 2022
@tolusha tolusha marked this pull request as draft October 5, 2022 16:01
@tolusha tolusha marked this pull request as ready for review October 5, 2022 16:02
@openshift-ci openshift-ci bot removed the lgtm label Oct 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-devworkspace-happy-path 57981e2 link true /test v11-devworkspace-happy-path
ci/prow/v11-operator-test 57981e2 link true /test v11-operator-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 0372333 into main Oct 6, 2022
@tolusha tolusha deleted the 21695 branch October 6, 2022 06:50
@che-bot che-bot added this to the 7.55 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants