-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use legacy routes if subdomain is too long #1702
Conversation
Signed-off-by: David Kwon <dakwon@redhat.com>
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #1702 +/- ##
==========================================
+ Coverage 60.18% 60.21% +0.02%
==========================================
Files 71 71
Lines 8430 8436 +6
==========================================
+ Hits 5074 5080 +6
Misses 3008 3008
Partials 348 348
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @tolusha, I will merge once the checks pass |
/retest |
Build 3.8 :: operator_3.x/250: Console, Changes, Git Data |
Build 3.8 :: sync-to-downstream_3.x/3647: Console, Changes, Git Data |
Build 3.8 :: operator-bundle_3.x/1515: Console, Changes, Git Data |
Build 3.8 :: sync-to-downstream_3.x/3648: Console, Changes, Git Data |
Build 3.8 :: push-latest-container-to-quay_3.x/2671: Console, Changes, Git Data |
Build 3.8 :: push-latest-container-to-quay_3.x/2672: Console, Changes, Git Data |
Build 3.8 :: get-sources-rhpkg-container-build_3.x/3489: devspaces-operator : 3.x :: Build 53196604 : quay.io/devspaces/devspaces-rhel8-operator:3.8-5 |
Build 3.8 :: operator_3.x/250: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3647 triggered |
Build 3.8 :: copyIIBsToQuay/1489: Console, Changes, Git Data |
Build 3.8 :: sync-to-downstream_3.x/3648: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3490 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.8 :: operator-bundle_3.x/1515: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3648 triggered |
Build 3.8 :: dsc_3.x/1026: Console, Changes, Git Data |
Build 3.8 :: update-digests_3.x/3441: Console, Changes, Git Data |
Build 3.8 :: update-digests_3.x/3441: No new images detected: nothing to do! |
Build 3.8 :: dsc_3.x/1026: 3.8.0 CI |
Build 3.8 :: operator-bundle_3.x/1516: Console, Changes, Git Data |
Build 3.8 :: sync-to-downstream_3.x/3650: Console, Changes, Git Data |
Build 3.8 :: push-latest-container-to-quay_3.x/2674: Console, Changes, Git Data |
Build 3.8 :: copyIIBsToQuay/1490: Console, Changes, Git Data |
Build 3.8 :: sync-to-downstream_3.x/3650: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3492 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.8 :: operator-bundle_3.x/1516: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3650 triggered |
Build 3.8 :: dsc_3.x/1027: Console, Changes, Git Data |
Build 3.8 :: dsc_3.x/1027: 3.8.0 CI |
What does this PR do?
Valid subdomains for ingresses/routes must have a length of 63 or less. This PR verifies that the subdomain for public endpoints are a valid.
If the subdomain is not valid, legacy subdomain is being used
For example, the following ingress/route hostname is invalid:
in this case, the legacy version will be used:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Image:
quay.io/dkwon17/che-operator:legacyHostname
To test this PR,
<workspaceId>-tools-8080-list-all-food
exists with aspec.host
of<username>.<wkspname>.list-all-food.<INGRESS-DOMAIN>
list-all-food
endpoint in thetools container
to an endpoint name of 63 characters<workspaceId>-tools-8080-<endpointname>
with aspec.host
that follows the legacy format:PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.