Allow configuring pull policy (with Always by default for nightlies)
#57
Conversation
Signed-off-by: David Festal <dfestal@redhat.com>
in Che, Keycloak and Postgres deployments Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
| @@ -143,6 +147,8 @@ type CheClusterSpecAuth struct { | |||
| OauthSecret string `json:"oAuthSecret"` | |||
| // KeycloakImage is image:tag used in Keycloak deployment | |||
| KeycloakImage string `json:"identityProviderImage"` | |||
| // KeycloakImagePullPolicy is the image pull policy used in Keycloak registry deployment: default value is Always | |||
| KeycloakImagePullPolicy corev1.PullPolicy `json:"identityProviderImagePullPolicy"` | |||
There was a problem hiding this comment.
it's too bad we have Keycloak* varibles mixed in with identityProvider* images but that's a refactoring for another time :)
There was a problem hiding this comment.
Yeah, the problem here is that it would be a breaking change in the API. So we would have to manage several versions of the API, which is not straightforward afaik.
| @@ -57,3 +59,15 @@ const ( | |||
| DefaultSecurityContextFsGroup = "1724" | |||
| DefaultSecurityContextRunAsUser = "1724" | |||
| ) | |||
|
|
|||
| func DefaultPullPolicyFromDockerImage(dockerImage string) string { | |||
There was a problem hiding this comment.
I am surprised about that @nickboldt didn't comment about your usage of the docker word here :-)
There was a problem hiding this comment.
haha. He still can do a PR afterwards if he prefers other words :-)
|
Once this is merged, I expect to see Always as the pull policy here:
(Screenshot taken after doing a chectl operator deployment of che 7 nightly, with custom images. See https://github.com/redhat-developer/codeready-workspaces/blob/master/devdoc/building/che7-custom-resource-airgap.adoc for steps to reproduce.) |
|
Yes, exactly. |
|
If you use chectl, you can even have this today by overriding the |
|
So is this being merged for 7 RC5 / GA? |
Currently, the pull policy for the Che, Keycloak and Postgres containers is fixed and set at
IfNotPresent.Obviously this make the use of the
nightlyoperator (and nightly Che components) useless.This PR:
CheClustercustom resource to drive the image pull policy of the various Che components (Che, Keycloak, etc...)Alwaysif the related docker image tag islatestornightlyIfNotPresentin other casesPlease consider this PR as a followup of issue eclipse-che/che#13780 that was part of endgame plan.