Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use che-bot user and exported... #581

Merged
merged 2 commits into from
Dec 15, 2020
Merged

use che-bot user and exported... #581

merged 2 commits into from
Dec 15, 2020

Conversation

nickboldt
Copy link
Contributor

What does this PR do?

use che-bot user and exported GITHUB_TOKEN

Change-Id: Id01ec2aa6eeb39b793020aebe0d57858442b866f
Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit messasge above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt
use che-bot user and exported GITHUB_TOKEN
18536ea 
Change-Id: Id01ec2aa6eeb39b793020aebe0d57858442b866f
Signed-off-by: nickboldt <nboldt@redhat.com>
benoitf
benoitf approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the token will be automatically hidden as it's a secret (so no need of FORK_CLEAN)

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, nickboldt
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 15, 2020 •
edited
Loading

so no need of FORK_CLEAN

Yeah, I wasn't sure if it only does that inside the yaml, or also in nested shell script calls.

But also I need a version w/o the token so it's a clickable URL in the message at the end, if you don't have hub installed (running the script locally).

@nickboldt
tweak GIT_REMOTE_FORK_CLEAN so it's a more clickable link when echoin…
cd68282 
…g warning to console about hub not being installed

Change-Id: I81295419b687aecd12bab66f7299c0fcc4d231e2
Signed-off-by: nickboldt <nboldt@redhat.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@nickboldt nickboldt merged commit 238c9c5 into master Dec 15, 2020
@nickboldt nickboldt deleted the use-che-bot-and-token branch December 15, 2020 16:03
@nickboldt
Copy link
Contributor Author

running test in https://github.com/eclipse/che-operator/runs/1558228150?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@tolusha tolusha Awaiting requested review from tolusha

Assignees

@benoitf benoitf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickboldt @openshift-ci-robot @benoitf