Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount secrets in containers #595

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Mount secrets in containers #595

merged 3 commits into from
Dec 24, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 23, 2020 •
edited
Loading

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

eclipse-che/che#18607

What does this PR do

Allows to mount secrets as file or env variable in che/postgres/keycloak/registries containers.

@tolusha
Mount secrets in containes
14f78c1 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request Dec 23, 2020
Closed
56 tasks
mmorhun
mmorhun reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add explanation in the PR description what it does, why and how. It will simplify the review and also give a hint later if someone decides to look at it.

pkg/deploy/defaults.go Show resolved Hide resolved
pkg/deploy/deployment.go Outdated Show resolved Hide resolved
pkg/deploy/deployment.go Show resolved Hide resolved
pkg/deploy/deployment.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
pkg/controller/che/che_controller.go Outdated Show resolved Hide resolved
@tolusha
Minor changes
0ad9348 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request Dec 24, 2020
Closed
79 tasks
mmorhun
mmorhun approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolusha
Minor fixes
0079fa3 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 42684b8 into master Dec 24, 2020
@tolusha tolusha deleted the mountsecrets branch December 24, 2020 10:25
@skabashnyuk skabashnyuk mentioned this pull request Dec 30, 2020
Closed
@tolusha tolusha mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@AndrienkoAleksandr AndrienkoAleksandr

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolusha @openshift-ci-robot @AndrienkoAleksandr @mmorhun