Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Recreate strategy type for operator deployment #607

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 5, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do

Set Recreate strategy type for operator deployment.
Operator update fails after adding liveness and readiness probe.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request Jan 5, 2021
79 tasks
@tolusha tolusha requested a review from sleshchenko January 5, 2021 13:42
@tolusha tolusha closed this Jan 5, 2021
@tolusha tolusha deleted the setstrategytype branch January 5, 2021 14:10
@tolusha tolusha restored the setstrategytype branch January 5, 2021 14:53
@tolusha tolusha reopened this Jan 5, 2021
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to understand if it's possible to do a rolling update to avoid downtime while the cluster is pulling the image
But it makes sense to merge this PR to fix the described issues

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0, no idea what this change does or why it's helpful.

Also "Operator update fails after adding liveness and readiness probe" sounds like a problem ... is this attempting to solve that? You had the same comment on description of #608 too

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, sleshchenko, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit f73542a into master Jan 5, 2021
@tolusha tolusha deleted the setstrategytype branch January 5, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants