Bring che operator in line with the latest changes coming to Che server to support single-host mode. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support single-host mode.
metlos
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
3 tasks
|
@davidfestal could we please move this forward? |
nickboldt
reviewed
Sep 5, 2019
davidfestal
approved these changes
Sep 5, 2019
|
@metlos are we still waiting for something of can we merge this now ? |
|
@davidfestal we can merge this now |
davidfestal
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Che server will require different ingress annotations and a new config variable to support single-host mode. This brings the operator inline with what is going to be required once eclipse-che/che#14134 is merged.