Naming convention #49
Conversation
Details at eclipse-che/che-plugin-registry#55 Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 58.35% 58.77% +0.42%
==========================================
Files 8 8
Lines 802 803 +1
==========================================
+ Hits 468 472 +4
+ Misses 289 286 -3
Partials 45 45
Continue to review full report at Codecov.
|
cfg/cfg.go
Outdated
| "download-metas", | ||
| false, | ||
| "Download plugin metadata from registry instead of process already-downloaded metas", | ||
| ) |
There was a problem hiding this comment.
Removing this now would result in a minor version bump (0.16.x) and require changes in upstream Che.
There was a problem hiding this comment.
Yes, but I'm considering change version to v1.0.0 since it is backward incompatible and first number is supposed be reflect such changes. WDYT?
There was a problem hiding this comment.
I'm open to either option but worry we're not to the point of calling it a v1.0 release, especially with the various naming convention/registry changes still coming down the pipe. It's still okay to break backward compatibility in version zero so I'm leaning more in that direction.
|
Could you also remove |
What does this PR do?
Make broker download metas using new naming convention.
Details at eclipse-che/che-plugin-registry#55
Cleanup not needed code.
What issues does this PR fix or reference?
Related to eclipse-che/che-plugin-registry#55