This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Avoid the need to set userland-proxy #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
…unnecessary K8s servicesSigned-off-by: David Festal <dfestal@redhat.com> Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 62.38% 62.52% +0.13%
==========================================
Files 6 6
Lines 553 555 +2
==========================================
+ Hits 345 347 +2
Misses 182 182
Partials 26 26
Continue to review full report at Codecov.
|
amisevsk
approved these changes
May 10, 2019
davidfestal
changed the title
benoitf
approved these changes
May 14, 2019
benoitf
reviewed
May 14, 2019
benoitf
reviewed
May 14, 2019
Co-Authored-By: Florent BENOIT <fbenoit@redhat.com>
Co-Authored-By: Florent BENOIT <fbenoit@redhat.com>
ibuziuk
approved these changes
May 14, 2019
|
@amisevsk This might be interesting to create a minor version of the v17 release, no ? So that it would be used by upstream master ? at least to do it as soon as prod-preview will use the v3 plugin registry (if not already the case). wdyt ? |
|
@davidfestal |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since, in the current Che implementation, all plugin containers are run on the same POD as the Theia IDE container, let's change the default behavior of the plugin brokers to use
localhostas the IP of side-car plugin endpoints, instead of using the short service name, which, in some cases, cannot be reached.What issues does this PR fix or reference?
eclipse-che/che#11018
This should also fix issue redhat-developer/rh-che#1371 as mentionned in
redhat-developer/rh-che#1371 (comment)
Has this PR been tested ?
Tested on upstream Che on minishift, with the docker image corresponding to the (now merged) PR eclipse-che/che#13311