Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Print number of downloaded extensions for a plugin #66

Closed
wants to merge 1 commit into from

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 10, 2019

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Improves the log message while downloading extensions for a plugin. It will print the number of extension is being downloaded and the total number of extensions for a plugin.

Downloading VS Code extension 1 of 1 for plugin `redhat/vscode-xml/0.7.0`
Downloading VS Code extension 1 of 2 for plugin `redhat/java/0.38.0`
Downloading VS Code extension 2 of 2 for plugin `redhat/java/0.38.0`

This PR was done in context of testing Eclipse Che with a real project (eclipse-che/che#13679)

What issues does this PR fix or reference?

eclipse-che/che#13388

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha added the enhancement New feature or request label Jul 10, 2019
@tolusha tolusha self-assigned this Jul 10, 2019
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #66 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage    66.6%   66.66%   +0.05%     
==========================================
  Files           6        6              
  Lines         569      570       +1     
==========================================
+ Hits          379      380       +1     
  Misses        165      165              
  Partials       25       25
Impacted Files Coverage Δ
brokers/unified/vscode/broker.go 74.07% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1af897...5110600. Read the comment docs.

@rhopp
Copy link
Contributor

rhopp commented Jul 10, 2019

#13388 is not in the endgame plan AFAIK, so this PR will have to wait until Che 7.0 is released.

@sleshchenko
Copy link
Member

The same changes are already merged in #80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants