-
Notifications
You must be signed in to change notification settings - Fork 26
Start remote binary with override entry point #75
Start remote binary with override entry point #75
Conversation
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 67.17% 67.46% +0.29%
==========================================
Files 6 7 +1
Lines 591 664 +73
==========================================
+ Hits 397 448 +51
- Misses 168 181 +13
- Partials 26 35 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this PR vs #76, this one should be closed, right?
Description updated |
@amisevsk @davidfestal @sleshchenko @l0rd pr updated and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise, but I think we should have test cases for remote runtime injection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
InjectorContainerName = "remote-runtime-injector" | ||
|
||
RemoteEndPointExecutableEnvVar = "PLUGIN_REMOTE_ENDPOINT_EXECUTABLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EndPoint
-> Endpoint
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
What does this PR do?
At this pr I changed a bit model: applied Type field to the model.ChePlugin
Inject remote endpoint binary with override entrypoint sidecar containers. For this purpose we are using init container from che-theia editor-plugin:
Plugin broker should find this init container by name
remote-runtime-injector
and only for che-theia editor plugin. Then plugin-broker should analize env variables and volume from init container.REMOTE_ENDPOINT_VOLUME_NAME
env we are using to find one volume which should be shared with other sidecar containers. In this volume init container on start should copy remote binaryPLUGIN_REMOTE_ENDPOINT_EXECUTABLE
env will be shared with all sidecar containers.Also che-plugin-broker override entypoint for all sidecar containers to start remote plugin. But if sidecar container has in the meta.yaml already defined entrypoint che-plugin broker don't override it. It's mean that plugin writer could define do something and then start remote plugin(using env
PLUGIN_REMOTE_ENDPOINT_EXECUTABLE
).What issues does this PR fix or reference?
eclipse-che/che#13387