Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fresh udi image with jetbrains editor images #1280

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented May 9, 2022

What does this PR do?

Use fresh UDI image which contains e2fsprogs with IntelliJ IDEA Community Edition 2022 and PyCharm Community Edition 2022.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

Screenshot/screencast of this PR

Снимок экрана 2022-05-09 в 20 48 39

What issues does this PR fix or reference?

eclipse-che/che#21007

How to test this PR?

Create the workspace from the following repository: https://github.com/vzhukovs/demo-repository/tree/che-idea-latest

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem reasonable assuming the 3.1GB quay.io/devfile/universal-developer-image:ubi8-9436df2 build from a few hours ago has what Jetbrains editors need.

@vzhukovs vzhukovs changed the title feat: use fresh udi image with jetbrains editor images chore: use fresh udi image with jetbrains editor images May 9, 2022
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@github-actions
Copy link

github-actions bot commented May 9, 2022

Click here to review and test in web IDE: Contribute

@openshift-ci openshift-ci bot added the lgtm label May 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, vzhukovs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vzhukovs vzhukovs merged commit a6778f8 into main May 9, 2022
@vzhukovs vzhukovs deleted the che#21007 branch May 9, 2022 19:33
@che-bot che-bot added this to the 7.48 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants