Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not ignore events and commands for an editor #1613

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Mar 20, 2023

What does this PR do?

At the moment there is a bug: events and commands defined for an editor in the che-editors.yaml file are ignored. See #1566 (review)
The PR fixes that problem.

What issues does this PR fix or reference?

eclipse-che/che#22071

How to test this PR?

  1. Define an event or command for an editor in the che-editors.yaml file.
  2. See feat: Use post-start event to start VS Code #1566 (review) for the next steps.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1613 (a27a3b4) into main (35dd161) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
+ Coverage   93.63%   93.68%   +0.05%     
==========================================
  Files          47       47              
  Lines        1445     1457      +12     
  Branches      247      253       +6     
==========================================
+ Hits         1353     1365      +12     
  Misses         92       92              
Impacted Files Coverage Δ
...ols/build/src/devfile/meta-yaml-to-devfile-yaml.ts 100.00% <100.00%> (ø)
...uild/src/editor/che-editors-meta-yaml-generator.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with local build and got a devfile.yaml for che-code with commads and events:

schemaVersion: 2.1.0
metadata:
  name: che-code
commands:
  - id: init-container-command
    apply:
      component: che-code-injector
  - id: init-che-code-command
    exec:
      component: che-code-runtime-description
      commandLine: nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &
events:
  preStart:
    - init-container-command
  postStart:
    - init-che-code-command
components:

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RomanNikitenko, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eclipse-che eclipse-che deleted a comment from openshift-ci bot Mar 21, 2023
@svor
Copy link
Contributor

svor commented Mar 21, 2023

/retest

1 similar comment
@svor
Copy link
Contributor

svor commented Mar 21, 2023

/retest

@RomanNikitenko
Copy link
Member Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants