Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vscode Github plugin #175

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Add Vscode Github plugin #175

merged 1 commit into from
Jul 5, 2019

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jul 2, 2019 •
edited by benoitf
Loading

@vinokurig vinokurig requested review from benoitf and evidolob July 2, 2019 07:39
benoitf
benoitf reviewed Jul 2, 2019
View reviewed changes
v3/plugins/ms-vscode/vscode-git/latest/meta.yaml Outdated
icon: https://www.eclipse.org/che/images/logo-eclipseche.svg
repository: https://github.com/microsoft/vscode/tree/master/extensions/git
category: Other
firstPublicationDate: '2016-03-11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, AFAIK it's the date published on this registry no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it is the first commit date of the related repository, will fix that to the date of merge.

benoitf
benoitf reviewed Jul 2, 2019
View reviewed changes
v3/plugins/ms-vscode/vscode-github-pullrequest/latest/meta.yaml Outdated
icon: https://www.eclipse.org/che/images/logo-eclipseche.svg
repository: https://github.com/microsoft/vscode-pull-request-github
category: Other
firstPublicationDate: '2018-06-27'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same small remark there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix that to the date of merge.

@benoitf
Copy link
Contributor

benoitf commented Jul 2, 2019

@vinokurig could you please also reference eclipse-che/che#11867 in the description so we're sure it's part of 'must fix' PR

@l0rd l0rd mentioned this pull request Jul 2, 2019
Closed
@azatsarynnyy
Copy link
Member

These two plugins have latest versions without the corresponded particular versions (e.g. 1.0.0).
As I understand, latest should always correspond to some particular plugin version (copying it's meta.yaml).
Should the PR also add the concrete plugins' versions?

@vinokurig vinokurig force-pushed the vscode-git-github branch from 3adc349 to 9e95e75 Compare July 3, 2019 12:05
@vinokurig
Copy link
Contributor Author

vinokurig commented Jul 3, 2019 •
edited
Loading

@azatsarynnyy Added concrete versions to all plugins

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2019

Hello, I'm thinking as git is quite a "default" extension, it should be included in the default che-theia image and not be part of the registry

@benoitf benoitf self-requested a review July 3, 2019 13:05
@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2019

could be hooked in https://github.com/eclipse/che-theia/blob/master/dockerfiles/theia/Dockerfile#L85-L86 and https://github.com/eclipse/che-theia/blob/master/dockerfiles/theia/Dockerfile#L108

@vinokurig
Copy link
Contributor Author

@benoitf

Hello, I'm thinking as git is quite a "default" extension, it should be included in the default che-theia image and not be part of the registry

The VsCode git plugin is built from vscode build scripts that are located in the vscode repository, can we include the vsix file to the che-theia build?

@benoitf
Copy link
Contributor

benoitf commented Jul 3, 2019

@vinokurig AFAIK yes
you just use curl or wget to grab it from https://github.com/che-incubator/vscode-git/releases

@vinokurig vinokurig force-pushed the vscode-git-github branch from 9e95e75 to 7237b0d Compare July 4, 2019 07:02
@vinokurig vinokurig changed the title Add Vscode Git and Github plugins Add Vscode Github plugin Jul 4, 2019
@vinokurig
Copy link
Contributor Author

@benoitf

@benoitf
Copy link
Contributor

benoitf commented Jul 4, 2019

@vinokurig thanks

benoitf
benoitf approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'ved added in the description link to eclipse-che/che#11867 as it's a must-have PR

@vinokurig vinokurig force-pushed the vscode-git-github branch from 7237b0d to 0130002 Compare July 4, 2019 10:54
@vinokurig
Add Vscode Github plugin
10dc2e8 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig force-pushed the vscode-git-github branch from 0130002 to 10dc2e8 Compare July 4, 2019 10:59
@vinokurig vinokurig merged commit 474ade7 into master Jul 5, 2019
@vinokurig vinokurig deleted the vscode-git-github branch July 5, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@l0rd l0rd l0rd approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@rhopp rhopp Awaiting requested review from rhopp

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinokurig @benoitf @azatsarynnyy @l0rd