Add 7.3.2 and 7.3.3 versions of che-theia/che-machine-exec #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the 7.3.2 and 7.3.3 bugfix version of che-machine-exec and che-theia to master branch to ensure compatibility when updating Che. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
ibuziuk,
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
2 tasks
ibuziuk
approved these changes
Dec 10, 2019
21 tasks
nickboldt
requested changes
Dec 10, 2019
|
Alternative idea... can the plugin broker, if it is asked for a version that doesn't exist... simply grab /latest as a fallback behaviour? Better that than:
|
I believe we should follow the flow we had since the very beginning related to backward compatibility.
yes, there is an rh-che issue for that redhat-developer/rh-che#1396 |
nickboldt
approved these changes
Dec 10, 2019
|
Agreed, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the 7.3.2 and 7.3.3 bugfix version of che-machine-exec and che-theia to master branch to ensure compatibility when updating Che.
Metas are copied from 7.3.3 tag.
Fixes eclipse-che/che#15444 for future releases.