Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new scopes to the generate GitHub token request #335

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jul 26, 2022

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

In order to meet the token requierments of the vscode-github-pull-request extension, add new token scopes when requesting a GitHub token.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#21581
fixes eclipse-che/che#21587

How to test this PR?

  1. Deploy Che with the che-server image from the PR: chectl server:deploy -p=openshift -i=quay.io/ivinokur/che-server:next1.
  2. Configure Github oAuth.
  3. Create a factory with a GitHub repo e.g. https://github.com/vinokurig/test.git.

See: GitHub will ask you to generate a token with "repo", "user:email", "read:user", "workflow" scopes:
screenshot-github com-2022 07 27-11_59_07

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig merged commit d6778f6 into main Jul 27, 2022
@vinokurig vinokurig deleted the che-21581 branch July 27, 2022 10:11
@che-bot che-bot added this to the 7.52 milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the workflow scope to the generated GitHub token
3 participants