Add a null check before reading GitHub response

[vinokurig]

What does this PR do?

Add a null check to prevent NullPointer exception while reading body from the GitHub API response. response.body() should not return null according to the java documentation, but the NullPointer exception was found in the customer debug logs:

Caused by: java.lang.NullPointerException: null
	at java.base/java.io.Reader.<init>(Reader.java:168)
	at java.base/java.io.InputStreamReader.<init>(InputStreamReader.java:112)
	at org.eclipse.che.api.factory.server.github.GithubApiClient.executeRequest(GithubApiClient.java:278)
	at org.eclipse.che.api.factory.server.github.GithubApiClient.getLatestCommit(GithubApiClient.java:184)
	at org.eclipse.che.api.factory.server.github.GithubURLParser.getLatestCommit(GithubURLParser.java:251)
	at org.eclipse.che.api.factory.server.github.GithubURLParser.parse(GithubURLParser.java:163)
	at org.eclipse.che.api.factory.server.github.GithubURLParser.parse(GithubURLParser.java:115)
	at org.eclipse.che.api.factory.server.github.GithubFactoryParametersResolver.createFactory(GithubFactoryParametersResolver.java:124)
	at org.eclipse.che.api.factory.server.FactoryService.resolveFactory(FactoryService.java:111)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4506

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[ibuziuk]

/retest

[ibuziuk]

can we add the test for that?

[vinokurig]

@ibuziuk

can we add the test for that?

done

[vinokurig]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.10 :: server_3.x/239: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: server_3.x/238: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4695: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4491: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4696: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4492: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.x/3313: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4491:

server : 3.x :: Build 55672011 : quay.io/devspaces/server-rhel8:3.10-9
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3313 triggered

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.x/3314: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: server_3.x/238:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4695 triggered

[devstudio-release]

Build 3.10 :: update-digests_3.x/4360: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: operator-bundle_3.x/2072: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4492:

server : 3.x :: Build 55672102 : quay.io/devspaces/server-rhel8:3.10-10
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3314 triggered

[devstudio-release]

Build 3.10 :: server_3.x/239:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4696 triggered

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4697: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4493: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.x/3315: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: copyIIBsToQuay/1918: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4493:

devspaces-operator-bundle : 3.x :: Build 55672242 : quay.io/devspaces/devspaces-operator-bundle:3.10-56
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3315 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.10-54
- quay.io/devspaces/configbump-rhel8:3.10-11
- quay.io/devspaces/dashboard-rhel8:3.10-18
- quay.io/devspaces/devfileregistry-rhel8:3.10-37
- quay.io/devspaces/devspaces-rhel8-operator:3.10-6
- quay.io/devspaces/idea-rhel8:3.10-2
- quay.io/devspaces/pluginregistry-rhel8:3.10-9
- quay.io/devspaces/server-rhel8:3.10-10
- quay.io/devspaces/traefik-rhel8:3.10-4
- quay.io/devspaces/udi-rhel8:3.10-5
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202308291001.p0.g94f3fde.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202308281924.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4697:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4493 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.10 :: operator-bundle_3.x/2072:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4697 triggered

[devstudio-release]

Build 3.10 :: dsc_3.x/1379: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: update-digests_3.x/4360:

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2072 triggered

[devstudio-release]

Build 3.10 :: update-digests_3.x/4361: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: update-digests_3.x/4361:

No new images detected: nothing to do!