Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: che-22646 use gh instead of hub #604

Merged
merged 1 commit into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,10 @@ jobs:
run: |
sudo apt-get update -y || true
# install more dependencies
sudo apt-get -y -q install wget curl bash git hub
sudo apt-get -y -q install wget curl bash git
java -version

# want git >=2.24, hub >=2
hub --version # hub reports git version too
git --version
gh --version

# want >=5
bash --version
Expand Down
3 changes: 1 addition & 2 deletions make-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,7 @@ commitChangeOrCreatePR() {
git checkout "${PR_BRANCH}"
git pull origin "${PR_BRANCH}" || true
git push origin "${PR_BRANCH}"
lastCommitComment="$(git log -1 --pretty=%B)"
hub pull-request -f -m "${lastCommitComment}" -b "${aBRANCH}" -h "${PR_BRANCH}"
gh pr create -f -B "${aBRANCH}" -H "${PR_BRANCH}"
fi
set -e
}
Expand Down