Expand the raw devfile url resolver pattern with token query parameter #616
Conversation
vinokurig
requested review from
l0rd,
ibuziuk,
nickboldt and
tolusha
as code owners
|
/retest |
| @@ -40,6 +41,7 @@ public class RawDevfileUrlFactoryParameterResolver extends BaseFactoryParameterR | |||
| implements FactoryParametersResolver { | |||
|
|
|||
| private static final String PROVIDER_NAME = "raw-devfile-url"; | |||
| private static final Pattern PATTERN = Pattern.compile("^https?://.*\\.ya?ml(\\?token=.*)?$"); | |||
There was a problem hiding this comment.
How is this token used later?
There was a problem hiding this comment.
We have not respected it yet
There was a problem hiding this comment.
I mean the token is a part of the URL, we do not use it but it is needed for the http request.
|
Verified on Che with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Rework the
accept()check in the raw devfile url resolver to respect token query parameters e.g.https://raw.githubusercontent.com/vinokurig/private/main/devfile.yaml?token=<token>Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#22685
fixes eclipse-che/che#22684
How to test this PR?
quay.io/eclipse/che-server:pr-616see: devfile is resolved and the workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.