-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support raw devfile urls without yaml extension #683
Conversation
.../src/main/java/org/eclipse/che/api/factory/server/RawDevfileUrlFactoryParameterResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ivinokur <ivinokur@redhat.com>
…i/factory/server/RawDevfileUrlFactoryParameterResolver.java Co-authored-by: Anatolii Bazko <abazko@redhat.com>
/retest |
/retest |
2 similar comments
/retest |
/retest |
devfileParser.parseYaml(fetch); | ||
return true; | ||
} catch (IOException | DevfileFormatException e) { | ||
return !e.getMessage().startsWith("Cannot construct instance of"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds unclear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworked to parsing raw yaml
/retest |
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The |
@vinokurig the @RomanNikitenko said this problem was resolved in the Anyway I've checked the functionality related to the PR and OAuth - works properly. |
The PR image is already up to date with the |
@artaleks9 If the failure is a known issue, can we go with the current changes? |
I see on the screenshot that editor version is pretty old - it was built 2 weeks ago. |
| @artaleks9 If the failure is a known issue, can we go with the current changes? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.15 :: server_3.x/339: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6816: Console, Changes, Git Data |
Build 3.15 :: push-latest-container-to-quay_3.x/4649: Console, Changes, Git Data |
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6766: server : 3.x :: Build 61397668 : quay.io/devspaces/server-rhel8:3.15-1 |
Build 3.15 :: server_3.x/339: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6816 triggered |
Build 3.15 :: update-digests_3.x/6641: Console, Changes, Git Data |
Build 3.15 :: operator-bundle_3.x/3012: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6817: Console, Changes, Git Data |
Build 3.15 :: get-sources-rhpkg-container-build_3.x/6767: devspaces-operator-bundle : 3.x :: Failed in 61398909 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
On handling raw devfile urls, request content by the url, and check if the content is a devfile. If yes treat the url as a raw devfile url.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#22937
How to test this PR?
quay.io/eclipse/che-server:pr-683
yaml
extension, e.g.https://raw.githubusercontent.com/vinokurig/test/master/parent
See: workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.