This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
chore: Rework GitHub authentication flow #1293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Exclude che-server requests from the GitHub authentication flow, instead read credentials file, mounted from the
github-credentials-secret
and extract the GitHub token.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#20995
fixes eclipse-che/che#20788
How to test this PR?
<che-url>/#https://github.com/vinokurig/test-extension/tree/devfile2
to authenticate GitHub for the user namespace.Git: Clone
and input a git url to a private repo e.g.https://github.com/vinokurig/test-extension.git
:PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable