Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add docker file to prepare PHP dev image #239

Closed
wants to merge 1 commit into from
Closed

Add docker file to prepare PHP dev image #239

wants to merge 1 commit into from

Conversation

svor
Copy link
Contributor

@svor svor commented May 22, 2019

Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com

What does this PR do?

Adds a docker file to prepare an image that is to be used in Che7 for PHP stack inside dev container. This image includes all the pre-requisite packages required to run the PHP applications.

What issues does this PR fix or reference?

eclipse-che/che#13307

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor self-assigned this May 22, 2019
@svor
Copy link
Contributor Author

svor commented May 22, 2019

ci-build

#add composer
COPY --from=composer:latest /usr/bin/composer /usr/bin/composer

WORKDIR /projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, there is no plugin endpoint in that image ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, it think there isn't. This image extends official php:7-apache and will be used in dev container in PHP stack

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be part of https://github.com/eclipse/che-dockerfiles instead then ? if there is no link with theia

@svor
Copy link
Contributor Author

svor commented May 22, 2019

probably it should, @benoitf maybe you know whom should I ask to build and push this image into dockerhub?

@benoitf
Copy link
Contributor

benoitf commented May 22, 2019

some of images are built from this file
https://github.com/CentOS/container-index/blob/master/index.d/che-stacks.yaml

for dockerhub it was Roman or Eugene...

@svor
Copy link
Contributor Author

svor commented May 22, 2019

In my case the image is based on Debian not CentOS, so, I think https://github.com/CentOS/container-index/blob/master/index.d/che-stacks.yaml doesn't work for me

@benoitf
Copy link
Contributor

benoitf commented May 22, 2019

I think autobuild images were setup on dockerhub but I don't have credentials

@svor
Copy link
Contributor Author

svor commented May 23, 2019

Moved this PR into eclipse/che-dockerfiles repo eclipse-che/che-dockerfiles#246

@svor svor closed this May 23, 2019
@svor svor deleted the sv/php_dev branch May 23, 2019 07:03
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
Signed-off-by: svor <vsvydenk@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants