This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix preview URL panel to show the resolved URL instead of a server name. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
requested review from
evidolob,
vitaliy-guliy,
RomanNikitenko and
AndrienkoAleksandr
slemeur
approved these changes
Jul 2, 2019
evidolob
approved these changes
Jul 2, 2019
olexii4
approved these changes
Jul 2, 2019
RomanNikitenko
approved these changes
Jul 2, 2019
akurinnoy
added a commit
that referenced
this pull request
Jul 4, 2019
…me. (#318) * Fix preview URL panel to show the resolved URL instead of a server name. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! Fix preview URL panel to show the resolved URL instead of a server name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, Preview URL panel's view is a bit confusing because it doesn't show any URL at all. This PR modifies it in the way to replace a server name with a resolved URL. In same way it updates a task preview notification which appears on top of Theia's page once a task is started.
Screenshots
What issues does this PR fix or reference?
fix eclipse-che/che#13357
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com