This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update terminal extension to the theia 0.3.19 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use newer terminal api. Fix resize terminal content which was sent before terminal opening Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
benoitf
approved these changes
Jan 29, 2019
| "xterm": "3.9.1", | ||
| "@eclipse-che/workspace-client": "latest", | ||
| "@eclipse-che/api": "latest" | ||
| }, | ||
| "license": "EPL-2.0", | ||
| "devDependencies": { | ||
| "typescript": "2.9.2", | ||
| "typescript": "^3.1.3", |
There was a problem hiding this comment.
maybe remove carret (well that's fine as we got CQ on dev dependencies for a version and later but maybe best to stick with one version here)
| if (!IBaseTerminalServer.validateId(this.terminalId)) { | ||
| throw new Error('terminal is not started'); | ||
| } | ||
| // Exec server side unable to return real process pid. This information is incupsulated. |
There was a problem hiding this comment.
Suggested change
| // Exec server side unable to return real process pid. This information is incupsulated. | |
| // Exec server side unable to return real process pid. This information is encapsulated. |
| "xterm": "3.9.1", | ||
| "@eclipse-che/workspace-client": "latest", | ||
| "@eclipse-che/api": "latest" | ||
| }, | ||
| "license": "EPL-2.0", | ||
| "devDependencies": { | ||
| "typescript": "2.9.2", | ||
| "typescript": "^3.1.3", |
There was a problem hiding this comment.
Suggested change
| "typescript": "^3.1.3", | |
| "typescript": "3.1.3", |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
evidolob
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
#29
Use newer terminal api. Fix resize terminal content which was sent before terminal opening
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com