-
Notifications
You must be signed in to change notification settings - Fork 111
Validate SSH keys list before view/delete #448
Conversation
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
const getKeys = async (sshKeyManager: SshKeyManager): Promise<cheApi.ssh.SshPair[]> => { | ||
const keys: cheApi.ssh.SshPair[] = await sshKeyManager.getAll('vcs'); | ||
if (!keys || keys.length < 1) { | ||
throw new Error('No SSH key pairs has been defined.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSH Key Pair
or
SSH Key Pairs have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
try { | ||
keys = await getKeys(sshkeyManager); | ||
} catch (error) { | ||
theia.window.showWarningMessage(error.message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should say that we're trying to delete in warning message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
let keys: cheApi.ssh.SshPair[]; | ||
try { | ||
keys = await getKeys(sshkeyManager); | ||
} catch (error) { | ||
theia.window.showWarningMessage(error.message); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could move to a separate method as we're using twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the updates @vinokurig 👍
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
* Buildah base dev plugin * Buildah dev plugin 1.14.0 * Update reference to docker image * Change memory limitation to 1gb Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Validate SSH key list in the view / delete actions of the SSH Plugin
What issues does this PR fix or reference?
eclipse-che/che#14218
Release Notes
Docs PR